Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Node should only ping arrays within the zone on which the pod is scheduled #378

Merged

Conversation

lukeatdell
Copy link
Contributor

@lukeatdell lukeatdell commented Dec 16, 2024

Description

Driver node pods should only authenticate and probe arrays within the zone on which the pod is scheduled.
Driver controller pods will continue to probe all arrays.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1612

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • cert-csi for availability zones and as regression testing
  • multi-az e2e tests

service/controller.go Outdated Show resolved Hide resolved
service/node.go Outdated Show resolved Hide resolved
service/service.go Outdated Show resolved Hide resolved
service/controller_test.go Outdated Show resolved Hide resolved
@falfaroc falfaroc requested review from falfaroc and tdawe December 18, 2024 21:07
@lukeatdell lukeatdell merged commit cb1ecfd into feature/multi-availability-zone Dec 18, 2024
6 checks passed
@lukeatdell lukeatdell deleted the usr/falfaroc/multi-az-testing-fun branch December 18, 2024 21:16
falfaroc added a commit that referenced this pull request Dec 18, 2024
…is scheduled (#378)

* configure driver node service to only ping arrays in the same zone as the service.

Co-authored-by: Fernando Alfaro Campos <[email protected]>
Co-authored-by: Trevor Dawe <[email protected]>
falfaroc added a commit that referenced this pull request Dec 19, 2024
* Add availability zone secret and struct (#352)

* add availability zone secret and struct

* Add multi availability zone storage class (#353)

* Add Multi-Available Zone Functionality (#354)

* Add create volume processing for multi-az

* Adjust multi-az secret processing

* Rework secret processing

* Iterate through all topologies for a zone

* Test signing commit

* Cleanup secret retrieval and backwards compatibility of storage classes

* adapt to use new secret struct

* Add multi-az unit tests

* Fix golangci-lint issue

* Cleanup code logs

* Make zone take precendence during NodeGetInfo

* Update unit tests credentials

---------

Co-authored-by: Lau, Luke <[email protected]>

* Unit tests for Node Topologies (#358)

* Adding Unit tests

* fixing formatting issues

* Use generic zone labels (#360)

* Add zone volume creation integration tests (#359)

* Add zone volume creation integration tests

* Fix golangci-lint issue

* Create e2e zone tests

* Adjust indentation of template yaml files

* Adjust indentation of template yaml files

* Update e2e file names

* Format e2e files for golangci-lint

* Update e2e test scenarios

* Update pod templates

* Address PR comments

* Add README to e2e tests

* Update sts templates

* Added Integration tests for NodeGetInfo

* fixing linting checks

* Renaming function arguments

* Add Snapshot and Clone Support for Multi-Available Zone (#365)

* Add snapshot check and topology add during zone volume creation

* Add topology checks for clones

* Add zone snapshot and restore e2e test

* Address failed PR checks

* Update README

* Added e2e tests for clones

* Add snap and clone test (#371)

* Address PR comments

---------

Co-authored-by: Trevor Dawe <[email protected]>
Co-authored-by: Bharath Sreekanth <[email protected]>

* Driver Node should only ping arrays within the zone on which the pod is scheduled (#378)

* configure driver node service to only ping arrays in the same zone as the service.

Co-authored-by: Fernando Alfaro Campos <[email protected]>
Co-authored-by: Trevor Dawe <[email protected]>

* Fix rebase issues

* Address PR comments

* Address PR comments

* Address PR comments

---------

Co-authored-by: lukeatdell <[email protected]>
Co-authored-by: Lau, Luke <[email protected]>
Co-authored-by: Harshita Pandey <[email protected]>
Co-authored-by: Trevor Dawe <[email protected]>
Co-authored-by: Harshita Pandey <[email protected]>
Co-authored-by: Bharath Sreekanth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants